Improve text resolution of BaronCityOffice Marie note #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Oct 27, 2021
Scripts/Python/xDynTextDefs.py
Outdated
Comment on lines
56
to
57
| "bcoWrinkledNote": ( "Michelle", 24, (0,0,0,1), (0,0,0,0), 10, "BaronCityOffice.TextObjects.WrinkledNote", PtJustify.kLeftJustify ), | ||
| "WatsonLetter": ( "Courier", 10, (0,0,0,1), (0,0,0,0), 0, "City.TextObjects.WatsonLetter", PtJustify.kLeftJustify ), |
There was a problem hiding this comment.
Suggested change
| "bcoWrinkledNote": ( "Michelle", 24, (0,0,0,1), (0,0,0,0), 10, "BaronCityOffice.TextObjects.WrinkledNote", PtJustify.kLeftJustify ), | |
| "WatsonLetter": ( "Courier", 10, (0,0,0,1), (0,0,0,0), 0, "City.TextObjects.WatsonLetter", PtJustify.kLeftJustify ), | |
| "bcoWrinkledNote": ( "Michelle", 24, (0,0,0,1), (0,0,0,0), 10, "BaronCityOffice.TextObjects.WrinkledNote", PtJustify.kLeftJustify ), | |
| "WatsonLetter": ( "Courier", 10, (0,0,0,1), (0,0,0,0), 0, "City.TextObjects.WatsonLetter", PtJustify.kLeftJustify ), |
Pedantic whitespace trolling
This requires a corresponding change in BaronCityOffice_District_BCOWrinkledPaper.prp to double the size of the dynamic text map. The original code sets the font size to 10, but the game actually used size 12 instead (the lowest available size of the Michelle font), so this actually doubles the font size exactly (from 12 to 24).
dgelessus
force-pushed
the
uncrunch_bco_note
branch
from
e0f4bb2
to
1c7b1b5
Compare
Hoikas
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion change of H-uru/moul-assets#86. This doubles the font size and line spacing of the note, to match the doubled resolution of the dynamic text map.
The original code sets the font size to 10, but the game actually uses size 12 instead, because that's the lowest available size of the Michelle font. So really I am just changing the font size from 12 to 24, even though the original code says 10.